Merge pull request magento#79 from magento/minor-fixes

Reduce false-positive findings
fredden · Apr 1, 2019 · 489029a · 489029a
2 parents 8c978ca + af55901
commit 489029a
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 307 deletions.
diff --git a/Magento2/Sniffs/Performance/EmptyCheckSniff.php b/Magento2/Sniffs/Performance/EmptyCheckSniff.php
diff --git a/Magento2/Tests/Performance/EmptyCheckUnitTest.inc b/Magento2/Tests/Performance/EmptyCheckUnitTest.inc
diff --git a/Magento2/Tests/Performance/EmptyCheckUnitTest.php b/Magento2/Tests/Performance/EmptyCheckUnitTest.php
diff --git a/Magento2/ruleset.xml b/Magento2/ruleset.xml
@@ -120,6 +120,7 @@
     <rule ref="Magento2.Exceptions.DirectThrow">
         <severity>8</severity>
         <type>warning</type>
+        <exclude-pattern>*/Test/*</exclude-pattern>
     </rule>
     <rule ref="Magento2.Exceptions.ThrowCatch">
         <severity>8</severity>
@@ -213,10 +214,6 @@
         <severity>7</severity>
         <type>warning</type>
     </rule>
-    <rule ref="Magento2.Performance.EmptyCheck">
-        <severity>7</severity>
-        <type>warning</type>
-    </rule>
     <rule ref="Magento2.Strings.StringConcat">
         <severity>7</severity>
         <type>warning</type>
@@ -302,6 +299,7 @@
     <rule ref="PSR1.Files.SideEffects">
         <severity>6</severity>
         <type>warning</type>
+        <exclude-pattern>*/Test/*</exclude-pattern>
     </rule>
     <rule ref="PSR1.Methods.CamelCapsMethodName">
         <severity>6</severity>
@@ -449,10 +447,6 @@
     <rule ref="Squiz.Commenting.ClassComment.TagNotAllowed">
         <severity>0</severity>
     </rule>
-    <rule ref="Squiz.Commenting.FunctionCommentThrowTag">
-        <severity>5</severity>
-        <type>warning</type>
-    </rule>
     <rule ref="Squiz.PHP.CommentedOutCode">
         <properties>
             <property name="maxPercentage" value="80"/>

diff --git a/composer.json b/composer.json
@@ -6,7 +6,7 @@
         "AFL-3.0"
     ],
     "type": "phpcodesniffer-standard",
-    "version": "1.0.0",
+    "version": "1.0.1",
     "require": {
         "php": ">=5.6.0",
         "squizlabs/php_codesniffer": "~3.3.0"

diff --git a/composer.lock b/composer.lock