Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currency number list function #11

Merged
merged 7 commits into from
Apr 11, 2018

Conversation

chris-jamieson
Copy link
Contributor

In some situations, for instance when providing a list of ISO currency numbers for a validation schema (e.g. via Joi), it is really useful to simply be able to fetch a list of the currency numbers.

This PR adds a similar function to the existing codes() and countries() functions, called numbers(), which returns an array of the ISO numbers as strings.

@freeall
Copy link
Owner

freeall commented Mar 12, 2018

This looks good! One tiny thing, I'm ok with the tabs into spaces, but can you remove the ' -> " change? Then I'll merge it.

@chris-jamieson
Copy link
Contributor Author

@freeall thanks for taking a look and sorry for the slow response. I'm embarrassed to say I didn't even realise my editor's prettier plugin had made those changes - doh! My apologies.

Have reverted the double-quotes to single-quotes now. Thank you.

@freeall freeall merged commit 9d09714 into freeall:master Apr 11, 2018
@freeall
Copy link
Owner

freeall commented Apr 11, 2018

@jamiesoncj published as 1.2.0. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants