fix: Moving custom migrations from cd to export service #2196
+1,208
−683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-urbanski-freiheit-com
force-pushed
the
su-migrate-migrations-content
branch
from
0a6a5ae to
34decfe
Compare
sven-urbanski-freiheit-com
changed the title
sven-urbanski-freiheit-com
force-pushed
the
su-migrate-migrations-content
branch
4 times, most recently
from
4bb5e7f to
d277b91
Compare
sven-urbanski-freiheit-com
force-pushed
the
su-migrate-migrations-content
branch
from
f365bad to
2ed6d1d
Compare
miguel-crespo-fdc
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the custom db migrations from the cd-service to the manifest-repo-export-service.
The pure sql migrations are now run by both the cd-service and the manifest-repo-export-service.
Many functions just had to be moved to another service, hence the big git diff.
Now, the export-service takes care of the migrations during startup.
The cd-service does not run the migrations anymore during startup. Instead, it calls (and waits for) the export-service, which then handles the migrations.
This also adds a new helm parameter
cd.grpcMaxRecvMsgSize.Ref: SRX-V6RVYF