Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Expressions "Editor" and "Easing" tabs order #419

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

pgilfernandez
Copy link

A simple UX change but it is much more common that you want to edit an expression than adding a easing to your timeline, do you agree?

tabs

@rodlie
Copy link
Member

rodlie commented Jan 15, 2025

Some backstory...

The easing tab was made for my trainee (I had a Friction animation trainee from 2023-2024). A quick hack so he could add easing stuff on his animations (until I could implement it properly). This has been made redundant with the easing functions in the timeline.

So, we could probably just hide it, or remove it entirely.

@pgilfernandez
Copy link
Author

I understand.
I guess the is redundant and not as easy to use as the one in the Graph editor... I would remove it then from the Expressions popup, it would be cleaner.

@rodlie
Copy link
Member

rodlie commented Jan 15, 2025

We can make them available as common functions when we implement #242 in v1.1.

@pgilfernandez
Copy link
Author

We can make them available as common functions when we implement #242 in v1.1.

Yes, good idea. It makes sense.

So, in the meantime, may we just disable the "Easing" tab or may we comment the tabs layout and move the "Editor" content out of the tab to be part of the window itself?

@rodlie rodlie merged commit b95cf04 into friction2d:main Jan 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants