Fix attr when $ collection contains text modules

frogman544 · Feb 28, 2014 · f8e3419 · f8e3419
1 parent 18bc828
commit f8e3419
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/api/attributes.js b/lib/api/attributes.js
@@ -55,6 +55,8 @@ var attr = exports.attr = function(name, value) {
       });
     }
     return domEach(this, function(i, el) {
+      if (!isTag(el)) return;
+
       if (typeof name === 'object') {
         _.each(name, function(name, key) {
           el.attribs[key] = name+'';

diff --git a/test/api.attributes.js b/test/api.attributes.js
@@ -33,6 +33,14 @@ describe('$(...)', function() {
       expect($pear.cheerio).to.not.be(undefined);
     });
 
+    it('(key, value) : should set attr', function() {
+      var $el = $('<div></div> <div></div>').attr('class', 'pear');
+
+      expect($el[0].attribs['class']).to.equal('pear');
+      expect($el[1].attribs).to.equal(undefined);
+      expect($el[2].attribs['class']).to.equal('pear');
+    });
+
     it('(key, value) : should return an empty object for an empty object', function() {
       var $src = $().attr('key', 'value');
       expect($src.length).to.equal(0);