Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing overrides #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mgerhardy
Copy link
Contributor

mkdir override
cd override
cmake -DTB_BUILD_DEMO=OFF -DCMAKE_CXX_CLANG_TIDY:STRING="clang-tidy-4.0;-checks=modernize-use-override;-fix" ..
cmake --build .

used clang-tidy

@fruxo
Copy link
Owner

fruxo commented Dec 10, 2016

Why is it that it wants override in these cases, and not in all the other hundreds of places i override virtual methods?

@mgerhardy
Copy link
Contributor Author

updated the pr manually. For me there are no warnings for -Winconsistent-missing-override when including turbobadger headers in my project. But it is possible that there are still warnings left if you compile turbobadger itself (I'm using different compiler flags for external code).

@mgerhardy
Copy link
Contributor Author

Looks like the tb namespace fix made it into this pr.. it should not be a problem because it's in master anyway already - if it is, let me know, then I will rebase this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants