Bump MSBuild.StructuredLogger to 2.1.820 #2746
Conversation
Updated with `paket update MSBuild.StructuredLogger --group fakemodule` Resolves: #2744
| Microsoft.Build.Framework (>= 16.10) | ||
| Microsoft.Build.Tasks.Core (>= 16.10) | ||
| Microsoft.Build.Utilities.Core (>= 16.10) | ||
| MSBuild.StructuredLogger (2.1.820) |
There was a problem hiding this comment.
2.1.545 August 2021 to 2.1.820 May 2023. https://www.nuget.org/packages/MSBuild.StructuredLogger
There was a problem hiding this comment.
Can we make it wildcard? 2.1.*
There was a problem hiding this comment.
Looks like it changes pretty often
There was a problem hiding this comment.
Should be (>= 2.1.0) right?
|
@gtbuchanan I'm a new maintainer. Do you want to finish your PR? |
|
So what needs to be done to get this finished? |
Or not, seems that updating the microsoft.build deps to 17.5 causes the integration tests to fail with the error described in #2722, so maybe leaving the min version at 2.1.815 that works with the older MSBuild versions would be safest (that should still support the v16 binlog format) |
|
@Numpsy OK, will you submit a PR? |
Description
Updated with
paket update MSBuild.StructuredLogger --group fakemoduleResolves: #2744
TODO
New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in
help/markdown)unit or integration test exists (or short reasoning why it doesn't make sense)
boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
(if new module) the module has been linked from the "side navigation" menu, edit
docs/data.json.(if new module) the module is in the correct namespace.
(if new module) the module is added to Fake.sln (
dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)Fake API guideline is honored