fixed camelCase/camel_case property conversion

furlat · Jan 21, 2018 · 931922a · 931922a
1 parent 9dc05cf
commit 931922a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/js/base/Exchange.js b/js/base/Exchange.js
@@ -140,11 +140,15 @@ module.exports = class Exchange {
 
         this.arrayConcat = (a, b) => a.concat (b)
 
-        const names = Object.getOwnPropertyNames (this).concat (
-                      Object.getOwnPropertyNames (this.constructor.prototype))
-
-        for (const k of names)
-            this[unCamelCase (k)] = this[k]
+        const unCamelCaseProperties = (obj = this) => {
+            if (obj !== null) {
+                for (const k of Object.getOwnPropertyNames (obj)) {
+                    this[unCamelCase (k)] = this[k]
+                }
+                unCamelCaseProperties (Object.getPrototypeOf (obj))
+            }
+       }
+       unCamelCaseProperties ()
 
     /*  exchange's capabilities (overrideable)      */
 

diff --git a/js/test/test_base.js b/js/test/test_base.js
@@ -476,6 +476,13 @@ describe ('ccxt base code', () => {
 
     })
 
+    it ('camelCase/camel_case property conversion works #2', () => {
+
+        class Derived extends ccxt.Exchange {}
+        const derived = new Derived ()
+        assert (typeof derived.load_markets === 'function')
+    })
+
     it ('legacy .hasSomething maps to has.something automatically', () => {
 
         const exchange = new ccxt.Exchange ({