Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24.2: Linter does not allow mandatory numeric parameter without value or value="" #19678

Open
bernt-matthias opened this issue Feb 21, 2025 · 0 comments

Comments

@bernt-matthias
Copy link
Contributor

bernt-matthias commented Feb 21, 2025

Describe the bug

For instance here the TestsCaseValidation linter reports:

Serious problem parsing tool source or tests - cannot validate test cases. The exception is []

The exception comes from here.

I do not see a reason why this should not be possible. Probably the solution is

            if value:
                float_value = float(value)
-            elif optional:
-                float_value = None
-            else:
-                raise ParameterDefinitionError()
+           else:
+               float_value = None

I remember that the TS errors on tools with numeric parameters without value attribute, where the solution is to add value="" ... Which also never made sense to me. See #16960 and #16966

In addition the ParameterDefinitionError exceptions in this file should probably include a descriptive text and ideally the parameter name.

Galaxy Version and/or server at which you observed the bug
Galaxy Version: 24.2?

To Reproduce

lint the linked tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant