Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New and updated queries for KUI #158

Merged
merged 2 commits into from
Jun 7, 2024
Merged

New and updated queries for KUI #158

merged 2 commits into from
Jun 7, 2024

Conversation

afgane
Copy link
Contributor

@afgane afgane commented Jun 6, 2024

Added a few queries to count number of datasets, histories, workflows, and workflow invocations as well as updated a few existing ones. Without these updates, when filtering by a given month, the queries were returning values spanning two months.

Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no complaints, this all looks good!

@@ -2452,7 +2523,7 @@ query_monthly-users-registered(){ ##? [--year=<YYYY>] [--month=<MM>] [--by_group

read -r -d '' QUERY <<-EOF
SELECT
TO_CHAR(date_trunc('month', galaxy_user.create_time AT TIME ZONE 'UTC')::DATE, 'YYYY-MM') AS month,
TO_CHAR(date_trunc('month', galaxy_user.create_time)::DATE, 'YYYY-MM') AS month,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone else added a timezone cast recently, I think I need to go through all of these and identify a policy (probably "don't AT TZ, fix your db") but that's a task for me for later.

@hexylena hexylena merged commit 90a69a4 into main Jun 7, 2024
1 check passed
@afgane afgane deleted the minimum-marsupial branch June 7, 2024 14:49
@afgane
Copy link
Contributor Author

afgane commented Jun 7, 2024

Thanks for the review and the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants