fix(fmt): respect bracket spacing in named function call (foundry-rs#…

…4363)

* fix(fmt): respect bracket spacing in named function call

* fix function call test

fmt/src/formatter.rs

@@ -2993,7 +2993,10 @@ impl<'a, W: Write> Visitor for Formatter<'a, W> {
         }
 
         if let Some(first) = chunks.first_mut() {
-            if first.prefixes.is_empty() && first.postfixes_before.is_empty() {
+            if first.prefixes.is_empty() &&
+                first.postfixes_before.is_empty() &&
+                !self.config.bracket_spacing
+            {
                 first.needs_space = Some(false);
             }
         }
@@ -3003,7 +3006,12 @@ impl<'a, W: Write> Visitor for Formatter<'a, W> {
         let prefix = if multiline && !self.is_beginning_of_line() { "\n" } else { "" };
         let closing_bracket = format!("{prefix}{}", "}");
         let closing_bracket_loc = args.last().unwrap().loc.end();
-        write_chunk_spaced!(self, closing_bracket_loc, Some(false), "{closing_bracket}")?;
+        write_chunk_spaced!(
+            self,
+            closing_bracket_loc,
+            Some(self.config.bracket_spacing),
+            "{closing_bracket}"
+        )?;
 
         Ok(())
     }

fmt/testdata/FunctionCall/bracket-spacing.fmt.sol

@@ -0,0 +1,37 @@
+// config: line_length = 120
+// config: bracket_spacing = true
+contract FunctionCall {
+    function foo() public pure {
+        bar(1111111111111111111111111111111111111111111111111111, 111111111111111111111111111111111111111111111111111);
+        bar(1111111111111111111111111111111111111111111111111112, 1111111111111111111111111111111111111111111111111112);
+        bar(1111111111111111111111111111111111111111111111111113, 11111111111111111111111111111111111111111111111111113); // the semicolon is not considered when determining line break
+        bar(
+            1111111111111111111111111111111111111111111111111114, 111111111111111111111111111111111111111111111111111114
+        );
+        bar(
+            111111111111111111111111111111111115,
+            11111111111111111111111111111111115,
+            11111111111111111111111111111111115
+        );
+        bar(
+            111111111111111111111111111111111111111111111111111116,
+            111111111111111111111111111111111111111111111111111116
+        );
+        bar(
+            111111111111111111111111111111111111111111111111111117,
+            1111111111111111111111111111111111111111111111111111117
+        );
+    }
+
+    function bar(uint256, uint256) private pure {
+        return;
+    }
+}
+
+function a(uint256 foo) {
+    foo;
+}
+
+function b() {
+    a({ foo: 5 });
+}

fmt/testdata/FunctionCall/fmt.sol

@@ -26,3 +26,11 @@ contract FunctionCall {
         return;
     }
 }
+
+function a(uint256 foo) {
+    foo;
+}
+
+function b() {
+    a({foo: 5});
+}

fmt/testdata/FunctionCall/original.sol

@@ -19,3 +19,11 @@ contract FunctionCall {
         return;
     }
 }
+
+function a(uint256 foo) {
+    foo;
+}
+
+function b() {
+    a( {foo: 5} );
+}

fmt/testdata/FunctionCallArgsStatement/fmt.sol

@@ -1,4 +1,3 @@
-// config: bracket_spacing = true
 interface ITarget {
     function run() external payable;
     function veryAndVeryLongNameOfSomeRunFunction() external payable;