Optimize toPath method by caching results (final-form#329)

* Optimize toPath performance by caching results * Update bundle size
gbakernet · Mar 30, 2020 · 359b7e7 · 359b7e7
1 parent fb0a46c
commit 359b7e7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -101,7 +101,7 @@
     },
     {
       "path": "dist/final-form.cjs.js",
-      "maxSize": "9.0kB"
+      "maxSize": "9.1kB"
     }
   ],
   "dependencies": {

diff --git a/src/structure/toPath.js b/src/structure/toPath.js
@@ -1,12 +1,18 @@
 // @flow
+const keysCache: {[string]: string[]} = {}
+const keysRegex = /[.[\]]+/;
+
 const toPath = (key: string): string[] => {
   if (key === null || key === undefined || !key.length) {
     return []
   }
   if (typeof key !== 'string') {
     throw new Error('toPath() expects a string')
   }
-  return key.split(/[.[\]]+/).filter(Boolean)
+  if(keysCache[key] == null) {
+    keysCache[key] = key.split(keysRegex).filter(Boolean)
+  }
+  return keysCache[key];
 }
 
 export default toPath