Skip to content

Commit

Permalink
J2534_WIN: Disabled outdated test.
Browse files Browse the repository at this point in the history
  • Loading branch information
diamondman committed Oct 14, 2017
1 parent 24f3f78 commit f1583cd
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions drivers/windows/pandaJ2534DLL Test/j2534_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1045,7 +1045,11 @@ namespace pandaJ2534DLLTest
j2534_recv_loop(chanid, 0);
}

//Check Single Frame tx RESETS ongoing multiframe rx transmission. 29 bit. Good Filter. NoPadding. STD address. Multi Frame.
//The documentation says that a s ingle channel can not send and receive messages trhough a
//single conversation (flow control filter) at the same time. However, the required behavior
//when this is detected is not described. This test was my best understanding of how it was
//wanted, but I no longer see the point. For now I am disabling it.
/*//Check Single Frame tx RESETS ongoing multiframe rx transmission. 29 bit. Good Filter. NoPadding. STD address. Multi Frame.
TEST_METHOD(J2534_ISO15765_PassRx_29b_Filter_NoPad_STD_SFTxResetsMFRx)
{
unsigned long chanid;
Expand Down Expand Up @@ -1080,7 +1084,9 @@ namespace pandaJ2534DLLTest
//Resume sending the old message, and check th eJ2534 device didn't get a message.
checked_panda_send(p, 0x18DAF1EF, TRUE, "\x22""NOPQRS", 7, 0, LINE_INFO());
j2534_recv_loop(chanid, 0);
}
}*/

//TODO check rx is cleared by tx (multi). Or not.... read above note.

//Check multiframe rx RESETS ongoing multiframe transmission. 29 bit. Good Filter. NoPadding. STD address. Multi Frame.
TEST_METHOD(J2534_ISO15765_PassRx_29b_Filter_NoPad_STD_FFCF_MFRxResetsMFRx)
Expand Down Expand Up @@ -1127,8 +1133,6 @@ namespace pandaJ2534DLLTest
j2534_recv_loop(chanid, 0);
}

//TODO check rx is cleared by tx (multi)

//Check rx fails gracefully if final CF of MF rx is too short. 29 bit. Good Filter. NoPadding. STD address. Multi Frame.
TEST_METHOD(J2534_ISO15765_FailRxFinalCFTooShort_29b_Filter_NoPad_STD_FFCF)
{
Expand Down

0 comments on commit f1583cd

Please sign in to comment.