fs: remove broken code in promises/write

That code expects the last argument to be a callback. When it's not a callback, it shifts arguments, defaulting encoding to 'utf-8', which is clearly broken. Old signature: (fd, string[, position[, encoding]], callback) New signature: (fd, string[, position[, encoding]]) PR-URL: nodejs#20407 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jamie Davis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
gcr · May 8, 2018 · ca6b12e · ca6b12e
1 parent dd03709
commit ca6b12e
Showing 1 changed file with 0 additions and 9 deletions.
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -244,15 +244,6 @@ async function write(handle, buffer, offset, length, position) {
 
   if (typeof buffer !== 'string')
     buffer += '';
-  if (typeof position !== 'function') {
-    if (typeof offset === 'function') {
-      position = offset;
-      offset = null;
-    } else {
-      position = length;
-    }
-    length = 'utf8';
-  }
   const bytesWritten = (await binding.writeString(handle.fd, buffer, offset,
                                                   length, kUsePromises)) || 0;
   return { bytesWritten, buffer };