log panics

geeker-zhou · May 16, 2017 · a7312f5 · a7312f5
1 parent 4cb22b5
commit a7312f5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/client/rpc_client.go b/client/rpc_client.go
@@ -98,7 +98,7 @@ func (r *rpcClient) call(ctx context.Context, address string, req Request, resp
 	go func() {
 		defer func() {
 			if r := recover(); r != nil {
-				ch <- errors.InternalServerError("go.micro.client", "request error")
+				ch <- errors.InternalServerError("go.micro.client", fmt.Sprintf("panic recovered: %v", r))
 			}
 		}()
 

diff --git a/server/rpc_server.go b/server/rpc_server.go
@@ -53,7 +53,8 @@ func (s *rpcServer) accept(sock transport.Socket) {
 		sock.Close()
 
 		if r := recover(); r != nil {
-			log.Log(r, string(debug.Stack()))
+			log.Log("panic recovered: ", r)
+			log.Log(string(debug.Stack()))
 		}
 	}()
 

diff --git a/transport/http_transport.go b/transport/http_transport.go
@@ -319,7 +319,7 @@ func (h *httpTransportListener) Accept(fn func(Socket)) error {
 			// TODO: think of a better error response strategy
 			defer func() {
 				if r := recover(); r != nil {
-					log.Logf("http: recovered %v", r)
+					log.Log("panic recovered: ", r)
 					sock.Close()
 				}
 			}()