Adding BA08 site term to ModifiableGMPE #10381
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micheles
reviewed
Feb 26, 2025
micheles
approved these changes
Feb 26, 2025
CB-quakemodel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Boore and Atkinson 2008 (/Atkinson and Boore 2006) site term to ModifiableGMPE + a unit test. Here is an example of the impact for an interface event with a focal depth of 40 km, and a site vs30 of 500 m/s:
The capability to apply the BA08 site term to the AtkinsonMacias2009 GMM through an
__init__argument is also added in this PR. We need to add as an input argument because the ModifiableGMPE class does not permit us to specify the required site term and basin term(s) in a single gsim class (similar to as detailed in the discussion within this previous PR for adding US 2023 basin terms to the AM09 and Z06 GMMs - #10156). The US 2023 unit tests are updated to check this input argument for the AM09 GMM. The following plot shows that the implementation is identical from either ModifiableGMPE or from the__init__argument approach (the green and red lines overlap exactly here ):Also fixing a docstring and a unit test name for the CB14 basin term unit test.