Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IpStack] Provide Administrative area #1246

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

sidz
Copy link
Contributor

@sidz sidz commented Feb 14, 2025

This PR provides an administrative area in the IpStack provider.

Requested in the #1055

@jbelien
Copy link
Member

jbelien commented Feb 16, 2025

Thanks for you contribution @sidz!

Could you make sure the tests and PHPCS fixed checks are passing so I can approve and merge your PR? Thanks.

@sidz sidz force-pushed the add-admin-levels-in-ip-stack branch from 36a36e8 to e6565dd Compare February 16, 2025 11:17
@sidz
Copy link
Contributor Author

sidz commented Feb 16, 2025

done @jbelien

@sidz sidz force-pushed the add-admin-levels-in-ip-stack branch from 8d08833 to 77ef6d2 Compare February 16, 2025 14:36
@sidz
Copy link
Contributor Author

sidz commented Feb 16, 2025

Rebased

@sidz sidz force-pushed the add-admin-levels-in-ip-stack branch from 77ef6d2 to f89d1fc Compare February 16, 2025 15:15
@jbelien jbelien merged commit d2e7419 into geocoder-php:master Feb 16, 2025
187 checks passed
@sidz sidz deleted the add-admin-levels-in-ip-stack branch February 16, 2025 16:02
@jbelien jbelien linked an issue Feb 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPStack provider doesn't set administration area.
2 participants