Small memory optimizations

geogubd · Aug 4, 2021 · 0c9f27e · 0c9f27e
1 parent 4d777d2
commit 0c9f27e
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 9 deletions.
diff --git a/build.cjs b/build.cjs
@@ -10,7 +10,7 @@ program.parse(process.argv);
 const options = program.opts();
 
 let esbuild_opts = {
-  sourcemap: !options.prod,
+  sourcemap: true,
   minify: options.prod,
   watch: options.watch,
   outdir: "dist",

diff --git a/examples/hatra/build.cjs b/examples/hatra/build.cjs
@@ -27,7 +27,7 @@ esbuild
   .build({
     entryPoints: ["src/index.tsx"],
     bundle: true,
-    sourcemap: !options.prod,
+    sourcemap: true,
     minify: options.prod,
     watch: options.watch,
     preserveSymlinks: true,

diff --git a/examples/slicing/build.cjs b/examples/slicing/build.cjs
@@ -25,7 +25,7 @@ const avoid_peerdep_conflicts_plugin = {
 };
 
 let esbuild_opts = {
-  sourcemap: !options.prod,
+  sourcemap: true,
   minify: options.prod,
   watch: options.watch,
   bundle: true,

diff --git a/src/definitions.tsx b/src/definitions.tsx
@@ -15,7 +15,7 @@ export interface DefinitionData {
 }
 
 export class AllDefinitionData {
-  @observable defs: { [name: string]: DefinitionData } = {};
+  @observable.shallow defs: { [name: string]: DefinitionData } = {};
   @observable def_mode: boolean = false;
   @observable used_definitions: Set<string> = new Set();
 

diff --git a/src/tex.tsx b/src/tex.tsx
@@ -109,7 +109,6 @@ export class TexContext {
     let defns = new H2R.ProcessNodeDefinitions(React);
     let instrs = [
       {
-        replaceChildren: true,
         shouldProcessNode: (node: any) => node.attribs && "data-cmd" in node.attribs,
         processNode: (node: any, children: any, index: any) => {
           let def = node.attribs["data-cmd"];
@@ -122,7 +121,6 @@ export class TexContext {
         },
       },
       {
-        replaceChildren: true,
         shouldProcessNode: (node: any) => node.attribs && "data-def" in node.attribs,
         processNode: (node: any, children: any, index: any) => {
           let def = node.attribs["data-def"];

diff --git a/src/togglebox.tsx b/src/togglebox.tsx
@@ -2,7 +2,6 @@ import React, { useState, useRef, useEffect, useCallback, forwardRef, CSSPropert
 import { useSynchronizer, useStateOnInterval } from "./utils";
 import classNames from "classnames";
 
-
 interface ToggleboxProps {
   Inside: React.FC;
   Outside: React.FC;
@@ -27,8 +26,8 @@ export let Togglebox: React.FC<ToggleboxProps> = ({ Inside, Outside, resize, reg
 
   if (registerToggle) {
     useEffect(() => {
-      registerToggle((show: boolean) => set_show_inside(show));
-    }, []);
+      registerToggle(set_show_inside);
+    }, [registerToggle]);
   }
 
   let style = useStateOnInterval({}, 1000, () => {