Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Update rails to v7.2 #2894

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

misc: Update rails to v7.2 #2894

wants to merge 12 commits into from

Conversation

ancorcruz
Copy link
Contributor

@ancorcruz ancorcruz commented Nov 29, 2024

Context

In order to update Rails to v8.0 first we update its version to the next and latest minor rails v7 version (v7.2.x)

Description

  • rails is updated from 7.1.2.4 to 7.2.2

Impact

all tests now respect the active_job.queue_adapter config link

rails configuration files updated.

Ruby YJIT is disabled as we are not ready because of the usage of OpenStruct for service result responses.

APP is live in: https://rails72-app.staging.getlago.com/

@ancorcruz ancorcruz self-assigned this Nov 29, 2024
julienbourdeau added a commit that referenced this pull request Jan 20, 2025
## Context

Let's get ready for Rails 7.2

## Description

I was looking at [Ancor's
PR](#2894) to upgrade to Rails
7.2 and I thought we could extracted the enum changes to a separate PR
since the syntax is already available.

Rails 7.2 will show a warning if we keep using the previous syntax (with
a hash) and 8.0 will remove it entirely.


https://blog.saeloun.com/2021/02/26/rails-introduces-new-syntax-for-enum/
@ancorcruz ancorcruz marked this pull request as ready for review February 4, 2025 10:37
@ancorcruz ancorcruz requested review from jdenquin, nudded, julienbourdeau and vincent-pochet and removed request for jdenquin February 5, 2025 09:25
@ancorcruz ancorcruz changed the title misc: Update rails to v7.2 (WIP) misc: Update rails to v7.2 Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant