-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: Update rails to v7.2 #2894
Open
ancorcruz
wants to merge
12
commits into
main
Choose a base branch
from
misc/rails-7-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
added a commit
that referenced
this pull request
Jan 20, 2025
## Context Let's get ready for Rails 7.2 ## Description I was looking at [Ancor's PR](#2894) to upgrade to Rails 7.2 and I thought we could extracted the enum changes to a separate PR since the syntax is already available. Rails 7.2 will show a warning if we keep using the previous syntax (with a hash) and 8.0 will remove it entirely. https://blog.saeloun.com/2021/02/26/rails-introduces-new-syntax-for-enum/
ancorcruz
force-pushed
the
misc/rails-7-2
branch
from
February 4, 2025 09:32
8c881c8
to
ea6264c
Compare
ancorcruz
requested review from
jdenquin,
nudded,
julienbourdeau and
vincent-pochet
and removed request for
jdenquin
February 5, 2025 09:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In order to update Rails to v8.0 first we update its version to the next and latest minor rails v7 version (v7.2.x)
Description
rails
is updated from7.1.2.4
to7.2.2
Impact
all tests now respect the
active_job.queue_adapter
config linkrails configuration files updated.
Ruby YJIT is disabled as we are not ready because of the usage of OpenStruct for service result responses.
APP is live in: https://rails72-app.staging.getlago.com/