feat: allow origin fields with cacheBehavior #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdominguezg
changed the title
|
@mnapoli hey! could you take a look on this please? |
|
Hi, I'm sorry but I don't think this is something we want to add to Lift. We don't want to add every option available to constructs. |
|
I see, so do you have any recommendation to implement this apart of forking? |
|
I would recommend to "eject" from Lift: https://github.com/getlift/lift#ejecting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to add the origins in order to use API Gateway resources. Tested with extensions but didn't work, so I've implemented another fields to do that.
I've added a new test and also tested in an internal project as a PoC and it works as expected. I updated the docs.