Skip to content

Commit

Permalink
Merge pull request #128 from willglynn/test/remove-reqwest
Browse files Browse the repository at this point in the history
Remove the reqwest dependency

This removes the dev dependency to reqwest, which was used by tests to
download fixtures from the Microsoft symbol server. Before Rust edition 2021,
the dependency resolver would not exclude optional features from dev
dependencies when running a crate build.

Developers now need to run the download script manually once a new fixture is
added. If files are missing, the tests will print instructions.

Originally submitted by @RazrFalcon in #71.
  • Loading branch information
jan-auer authored Jun 3, 2022
2 parents 2d164d3 + 5319bb6 commit 35a935d
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 1,236 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ jobs:

- uses: swatinem/rust-cache@v1

- name: Download Fixtures
run: scripts/download

- name: Run Cargo Tests
uses: actions-rs/cargo@v1
with:
Expand Down
Loading

0 comments on commit 35a935d

Please sign in to comment.