-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(feedback): accessibility audit action items #4698
fix(feedback): accessibility audit action items #4698
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e0cc6ba | 1219.16 ms | 1240.32 ms | 21.16 ms |
caa37b6 | 1197.43 ms | 1211.52 ms | 14.09 ms |
6161814 | 1216.90 ms | 1233.18 ms | 16.29 ms |
9e96fd6 | 1207.20 ms | 1229.40 ms | 22.20 ms |
2172278 | 1229.58 ms | 1245.00 ms | 15.42 ms |
25bcc50 | 1240.47 ms | 1254.70 ms | 14.23 ms |
c4ef3ee | 1233.80 ms | 1258.92 ms | 25.12 ms |
c00eafe | 1253.04 ms | 1256.41 ms | 3.37 ms |
79239ff | 1223.53 ms | 1250.98 ms | 27.45 ms |
35647ef | 1250.42 ms | 1251.87 ms | 1.46 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e0cc6ba | 22.31 KiB | 768.83 KiB | 746.52 KiB |
caa37b6 | 21.58 KiB | 424.34 KiB | 402.76 KiB |
6161814 | 21.58 KiB | 713.97 KiB | 692.39 KiB |
9e96fd6 | 20.76 KiB | 425.80 KiB | 405.04 KiB |
2172278 | 21.58 KiB | 542.28 KiB | 520.70 KiB |
25bcc50 | 20.76 KiB | 427.22 KiB | 406.46 KiB |
c4ef3ee | 22.31 KiB | 760.27 KiB | 737.97 KiB |
c00eafe | 20.76 KiB | 432.88 KiB | 412.12 KiB |
79239ff | 22.31 KiB | 765.78 KiB | 743.46 KiB |
35647ef | 21.58 KiB | 706.97 KiB | 685.39 KiB |
Previous results on branch: armcknight/feat(feedback)/accessibility-audit
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3cbcd11 | 1220.02 ms | 1242.74 ms | 22.72 ms |
f6c0e85 | 1228.17 ms | 1257.04 ms | 28.87 ms |
01ccbc7 | 1225.10 ms | 1235.39 ms | 10.29 ms |
0acedc3 | 1237.90 ms | 1253.62 ms | 15.72 ms |
66c19de | 1232.45 ms | 1251.78 ms | 19.33 ms |
e3de806 | 1242.67 ms | 1262.22 ms | 19.56 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3cbcd11 | 22.31 KiB | 774.49 KiB | 752.17 KiB |
f6c0e85 | 22.31 KiB | 819.57 KiB | 797.26 KiB |
01ccbc7 | 22.31 KiB | 780.93 KiB | 758.61 KiB |
0acedc3 | 22.31 KiB | 780.06 KiB | 757.75 KiB |
66c19de | 22.31 KiB | 818.61 KiB | 796.29 KiB |
e3de806 | 22.31 KiB | 770.93 KiB | 748.62 KiB |
Sources/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackFormConfiguration.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments.
Sources/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackFormConfiguration.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift
Outdated
Show resolved
Hide resolved
…erFeedbackFormConfiguration.swift Co-authored-by: Philip Niedertscheider <[email protected]>
…ack)/accessibility-audit
…ack)/accessibility-audit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, smaller comments to decide at your discretion
Sources/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackFormConfiguration.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing more to add than @philprime. LGTM
…d-tripped to the ui tests
for #4401; #skip-changelog