Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feedback): accessibility audit action items #4698

Merged
merged 14 commits into from
Feb 12, 2025

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Jan 10, 2025

for #4401; #skip-changelog

Copy link

github-actions bot commented Jan 10, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.51 ms 1235.63 ms 19.12 ms
Size 22.31 KiB 819.58 KiB 797.26 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e0cc6ba 1219.16 ms 1240.32 ms 21.16 ms
caa37b6 1197.43 ms 1211.52 ms 14.09 ms
6161814 1216.90 ms 1233.18 ms 16.29 ms
9e96fd6 1207.20 ms 1229.40 ms 22.20 ms
2172278 1229.58 ms 1245.00 ms 15.42 ms
25bcc50 1240.47 ms 1254.70 ms 14.23 ms
c4ef3ee 1233.80 ms 1258.92 ms 25.12 ms
c00eafe 1253.04 ms 1256.41 ms 3.37 ms
79239ff 1223.53 ms 1250.98 ms 27.45 ms
35647ef 1250.42 ms 1251.87 ms 1.46 ms

App size

Revision Plain With Sentry Diff
e0cc6ba 22.31 KiB 768.83 KiB 746.52 KiB
caa37b6 21.58 KiB 424.34 KiB 402.76 KiB
6161814 21.58 KiB 713.97 KiB 692.39 KiB
9e96fd6 20.76 KiB 425.80 KiB 405.04 KiB
2172278 21.58 KiB 542.28 KiB 520.70 KiB
25bcc50 20.76 KiB 427.22 KiB 406.46 KiB
c4ef3ee 22.31 KiB 760.27 KiB 737.97 KiB
c00eafe 20.76 KiB 432.88 KiB 412.12 KiB
79239ff 22.31 KiB 765.78 KiB 743.46 KiB
35647ef 21.58 KiB 706.97 KiB 685.39 KiB

Previous results on branch: armcknight/feat(feedback)/accessibility-audit

Startup times

Revision Plain With Sentry Diff
3cbcd11 1220.02 ms 1242.74 ms 22.72 ms
f6c0e85 1228.17 ms 1257.04 ms 28.87 ms
01ccbc7 1225.10 ms 1235.39 ms 10.29 ms
0acedc3 1237.90 ms 1253.62 ms 15.72 ms
66c19de 1232.45 ms 1251.78 ms 19.33 ms
e3de806 1242.67 ms 1262.22 ms 19.56 ms

App size

Revision Plain With Sentry Diff
3cbcd11 22.31 KiB 774.49 KiB 752.17 KiB
f6c0e85 22.31 KiB 819.57 KiB 797.26 KiB
01ccbc7 22.31 KiB 780.93 KiB 758.61 KiB
0acedc3 22.31 KiB 780.06 KiB 757.75 KiB
66c19de 22.31 KiB 818.61 KiB 796.29 KiB
e3de806 22.31 KiB 770.93 KiB 748.62 KiB

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 336 lines in your changes missing coverage. Please review.

Project coverage is 9.108%. Comparing base (f3b8999) to head (381e71f).
Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
...UserFeedback/SentryUserFeedbackFormViewModel.swift 0.000% 209 Missing ⚠️
...serFeedback/SentryUserFeedbackFormController.swift 0.000% 64 Missing ⚠️
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% 26 Missing ⚠️
Sources/Sentry/SentryScreenshot.m 0.000% 18 Missing ⚠️
...rFeedback/SentryUserFeedbackWidgetButtonView.swift 0.000% 13 Missing ⚠️
...Feedback/SentryUserFeedbackIntegrationDriver.swift 0.000% 3 Missing ⚠️
Sources/Sentry/SentryUserFeedbackIntegration.m 0.000% 2 Missing ⚠️
Sources/Sentry/PrivateSentrySDKOnly.mm 0.000% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f3b8999) and HEAD (381e71f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f3b8999) HEAD (381e71f)
2 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #4698        +/-   ##
=============================================
- Coverage   91.082%   9.108%   -81.975%     
=============================================
  Files          624      350       -274     
  Lines        72205    24934     -47271     
  Branches     25652       94     -25558     
=============================================
- Hits         65766     2271     -63495     
- Misses        6345    22663     +16318     
+ Partials        94        0        -94     
Files with missing lines Coverage Δ
...guration/SentryUserFeedbackFormConfiguration.swift 0.000% <ø> (ø)
Sources/Sentry/PrivateSentrySDKOnly.mm 1.257% <0.000%> (-23.000%) ⬇️
Sources/Sentry/SentryUserFeedbackIntegration.m 0.000% <0.000%> (-41.667%) ⬇️
...Feedback/SentryUserFeedbackIntegrationDriver.swift 0.000% <0.000%> (ø)
...rFeedback/SentryUserFeedbackWidgetButtonView.swift 0.000% <0.000%> (ø)
Sources/Sentry/SentryScreenshot.m 0.000% <0.000%> (-75.610%) ⬇️
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% <0.000%> (ø)
...serFeedback/SentryUserFeedbackFormController.swift 0.000% <0.000%> (ø)
...UserFeedback/SentryUserFeedbackFormViewModel.swift 0.000% <0.000%> (ø)

... and 639 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b8999...381e71f. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments.

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, smaller comments to decide at your discretion

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more to add than @philprime. LGTM

@armcknight armcknight merged commit 7b032f3 into main Feb 12, 2025
63 of 72 checks passed
@armcknight armcknight deleted the armcknight/feat(feedback)/accessibility-audit branch February 12, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants