feat(prevent): Redirect between TA onboard vs tests

[calvin-codecov]

Closes https://linear.app/getsentry/issue/CCMRG-1613/ta-redirection-for-onboarding-vs-test-results-page
Closes https://linear.app/getsentry/issue/CCMRG-1649/bug-multiple-app-installations-for-same-app-id-showing-up

[linear]

CCMRG-1613 TA Redirection for Onboarding vs Test Results Page

CCMRG-1649 BUG: Multiple App Installations for same app_id showing up

[cursor]

Bug: Null Assertion Error in API URL Construction

The useRepo hook and regenerateToken mutation use non-null assertions on integratedOrgId and repository from usePreventContext. These values can be undefined or null during initial render or before user selection, which results in malformed API URLs (e.g., /owner/undefined/repository/undefined/) and can cause API errors or runtime issues.

Additional Locations (3)

• static/app/views/prevent/tests/tests.tsx#L49-L54
• static/app/views/prevent/tests/onboarding.tsx#L59-L64
• static/app/views/prevent/tests/onboardingSteps/addUploadTokenStep.tsx#L88-L95

 

[seer-by-sentry]

Potential bug: The non-null assertion operator (!) is used on optional context fields integratedOrgId and repository, which can be undefined, causing a runtime error.

• Description: The context fields integratedOrgId and repository are defined as optional in PreventContextData. However, they are used with the non-null assertion operator (!) in addUploadTokenStep.tsx when calling the regenerateToken mutation, and also in onboarding.tsx within the useRepo hook. The logic in the context provider can result in these fields being undefined, for instance, when a user navigates directly to the page without URL parameters or existing localStorage state. This will cause an immediate JavaScript TypeError when the component renders or the mutation is called, leading to a runtime crash.

• Suggested fix: Before using integratedOrgId and repository, add a check to ensure they are defined. If they are not, you could show a loading state, an error message, or disable the functionality that depends on them until the values are available. Avoid using the non-null assertion operator without this validation.
  _{severity: 0.8, confidence: 0.95}

_{Did we get this right? 👍 / 👎 to inform future reviews.}