Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis CI to GitHub CI #824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Krinkle
Copy link

@Krinkle Krinkle commented Jan 20, 2025

It seems Travis CI is no longer available for pull requests and forks to run tests. In order for this to work by default and give feedback early, try GitHub CI instead.

@Krinkle Krinkle force-pushed the github-ci branch 8 times, most recently from df5f42b to 84b79a2 Compare January 20, 2025 21:00
@Krinkle
Copy link
Author

Krinkle commented Jan 20, 2025

https://github.com/Krinkle/kramdown/actions/runs/12876088956

I removed Ruby 2.3 and 2.4 from the test matrix because those were failing with:

 kramdown was resolved to 2.5.1, which depends on
      Ruby (>= 2.5)

  Current Ruby version:
    Ruby (= 2.4.10)

The profiler job was failing as follows, which I've fixed as well. To avoid surprise breakage in the future, I've made the job specify at least a major version (1.x) of memory_profiler.

…/gems/memory_profiler-1.1.0/lib/memory_profiler/results.rb:141:
  in `pretty_print': private method `puts' called for {:scale_bytes=>true}:Hash (NoMethodError)
  io.puts "Total allocated: #{total_allocated_output} (#{total_allocated} objects)"
    ^^^^^
  from /home/runner/work/kramdown/kramdown/benchmark/memory_profiler_preload.rb:33

It seems Travis CI is no longer available for pull requests and forks
to run tests. In order for this to work by default and give feedback
early, try GitHub CI instead.

Remove Ruby 2.3 and 2.4 from the matrix, because are no longer supported:

```
 kramdown was resolved to 2.5.1, which depends on
      Ruby (>= 2.5)

  Current Ruby version:
    Ruby (= 2.4.10)
```

Fix failure in profiler job:

```
…/gems/memory_profiler-1.1.0/lib/memory_profiler/results.rb:141:
  in `pretty_print': private method `puts' called for {:scale_bytes=>true}:Hash (NoMethodError)
  io.puts "Total allocated: #{total_allocated_output} (#{total_allocated} objects)"
    ^^^^^
  from /home/runner/work/kramdown/kramdown/benchmark/memory_profiler_preload.rb:33
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant