Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added class CommandManagerStateEvent. #162

Merged

Conversation

danfulton
Copy link
Contributor

@danfulton danfulton commented Feb 22, 2022

As reported in #117 , repeated CommandEvents were not showing up in the events queue when they occurred. When a CommandEvent is repeated, it is recorded as a CommandManagerStateEvent, presumably to save space. Added a class so these are now available.

Also some minor reformatting from running Black.

Resolves #117

@danfulton danfulton force-pushed the danfulton/bugfix-117-queued-units branch from ed305ca to 6b562fa Compare February 22, 2022 05:47
@danfulton
Copy link
Contributor Author

Was using an older version of Black, but fixed the linting check.

@danfulton danfulton force-pushed the danfulton/bugfix-117-queued-units branch from fecbc44 to 6b562fa Compare February 22, 2022 06:04
@danfulton
Copy link
Contributor Author

Reverting the super() call so the PR passes the Python 2 Circle CI check. I would suggest removing Python 2 check and updating all the Event classes at once to use the newer style if the project really is Python 3 only.

@cclauss
Copy link
Collaborator

cclauss commented Feb 22, 2022

My mistake — thanks for the revert. I opened #163

Copy link
Collaborator

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.

Copy link
Collaborator

@StoicLoofah StoicLoofah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. Thanks!

@StoicLoofah StoicLoofah merged commit 6ca2045 into ggtracker:upstream Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not showing event for queuing ordered units
3 participants