[MNG-6631] documented the performance intent

ghadishayban · Apr 27, 2019 · d34e8fb · d34e8fb
1 parent 44ad1aa
commit d34e8fb
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/...n-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java b/...n-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
@@ -221,12 +221,14 @@ private static Integer getNextIntegerToken( StringTokenizer tok )
 
     private static Integer tryParseInt( String s )
     {
+        // for performance, check digits instead of relying later on catching NumberFormatException
+        if ( !isDigits( s ) )
+        {
+            return null;
+        }
+
         try
         {
-            if ( !isDigits( s ) )
-            {
-                return null;
-            }
             long longValue = Long.parseLong( s );
             if ( longValue > Integer.MAX_VALUE )
             {
@@ -236,6 +238,7 @@ private static Integer tryParseInt( String s )
         }
         catch ( NumberFormatException e )
         {
+            // should never happen since checked isDigits(s) before 
             return null;
         }
     }