Add automatic tests using GitHub actions and fix all encountered bugs #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on issue #187 . I adopted the CI tests in the
testsfolder for GitHub actions, compiling and running the tests on Linux and macOS both for amd64 and arm64. The latest run with all tests passing can be found here.Running the test revealed some bugs which I directly took the liberty to fix. This includes a bug in the dgemm kernel for the X64_INTEL_SANDY_BRIDGE target and arm targets. I also fixed the kernel calling conventions on arm macOS for the single precision kernels and got rid of the x18 register in the correct places.
I also disabled that getrf test since they were failing due to different row pivots. I guess they are not necessary unique?