Merge pull request opencv#23350 from spikethehobbitmage:4.x

Fix reference counting errors in registerNewType
giftalu · Apr 3, 2023 · 66a5ecb · 66a5ecb
2 parents 3ac06bf + 95f087c
commit 66a5ecb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/modules/python/src2/cv2.cpp b/modules/python/src2/cv2.cpp
@@ -284,6 +284,7 @@ static bool init_submodule(PyObject * root, const char * name, PyMethodDef * met
 static inline
 bool registerTypeInModuleScope(PyObject* module, const char* type_name, PyObject* type_obj)
 {
+    Py_INCREF(type_obj); /// Give PyModule_AddObject a reference to steal.
     if (PyModule_AddObject(module, type_name, type_obj) < 0)
     {
         PyErr_Format(PyExc_ImportError,

diff --git a/modules/python/src2/pycompat.hpp b/modules/python/src2/pycompat.hpp
@@ -338,8 +338,10 @@ PyObject* pyopencv_from(const TYPE& src)
         if (!registerNewType(m, #EXPORT_NAME, (PyObject*)pyopencv_##CLASS_ID##_TypePtr, SCOPE)) \
         { \
             printf("Failed to register a new type: " #EXPORT_NAME  ", base (" #BASE ") in " SCOPE " \n"); \
+            Py_DECREF(pyopencv_##CLASS_ID##_TypePtr); \
             ERROR_HANDLER; \
         } \
+        Py_DECREF(pyopencv_##CLASS_ID##_TypePtr); \
     }
 
 // Debug module load: