refactor gin code logic #2790
Open
refactor gin code logic #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2790 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 41 41
Lines 2085 2088 +3
=======================================
+ Hits 2058 2061 +3
Misses 15 15
Partials 12 12
Continue to review full report at Codecov.
|
kszafran
reviewed
Jul 18, 2021
| func init() { | ||
| if engine == nil { | ||
| engine = gin.Default() | ||
| } |
There was a problem hiding this comment.
How is this different from just writing:
var engine = gin.Default()? I don't think you can change the value of the engine variable before init is executed, so the if condition will always be true.
| v.once.Do(func() { | ||
| // lazyInit initialize the validate Settings, no need to use sync.once | ||
| func (v *defaultValidator) lazyInit() { | ||
| if v.validate == nil { |
There was a problem hiding this comment.
I'm not sure if this is an improvement. I believe sync.Once was used to avoid race conditions. This version seems kind of safe, too, but it might call validator.New() multiple times unnecessarily. I don't see the point of eliminating sync.Once.
|
There is no need to use the once mechanism here. You are all using this mechanism indiscriminately.
…------------------ Original ------------------
From: kszafran ***@***.***>
Date: Mon,Jul 19,2021 0:30 AM
To: gin-gonic/gin ***@***.***>
Cc: heige ***@***.***>, Author ***@***.***>
Subject: Re: [gin-gonic/gin] refactor gin code logic (#2790)
@kszafran commented on this pull request.
In ginS/gins.go:
> -func engine() *gin.Engine { -once.Do(func() { -internalEngine = gin.Default() -}) -return internalEngine +func init() { +if engine == nil { +engine = gin.Default() +}
How is this different from just writing:
var engine = gin.Default()
? I don't think you can change the value of the engine variable before init is executed, so the if condition will always be true.
In binding/default_validator.go:
> return v.validate } -func (v *defaultValidator) lazyinit() { -v.once.Do(func() { +// lazyInit initialize the validate Settings, no need to use sync.once +func (v *defaultValidator) lazyInit() { +if v.validate == nil {
I'm not sure if this is an improvement. I believe sync.Once was used to avoid race conditions. This version seems kind of safe, too, but it might call validator.New() multiple times unnecessarily. I don't see the point of eliminating sync.Once.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
For engine, this is a variable, not the previous function mode. Even if the once mechanism is used, it is recommended to declare it as a private variable mode, which is better and more intuitive.
…------------------ Original ------------------
From: daheige ***@***.***>
Date: Mon,Jul 19,2021 7:52 AM
To: reply+ACMGV623UENNAYDFPQQH7KV7AA4DDEVBNHHDQTCOQU ***@***.***>, gin-gonic/gin ***@***.***>
Cc: daheige ***@***.***>, Author ***@***.***>
Subject: Re: [gin-gonic/gin] refactor gin code logic (#2790)
There is no need to use the once mechanism here. You are all using this mechanism indiscriminately.
------------------ Original ------------------
From: kszafran ***@***.***>
Date: Mon,Jul 19,2021 0:30 AM
To: gin-gonic/gin ***@***.***>
Cc: heige ***@***.***>, Author ***@***.***>
Subject: Re: [gin-gonic/gin] refactor gin code logic (#2790)
@kszafran commented on this pull request.
In ginS/gins.go:
> -func engine() *gin.Engine { -once.Do(func() { -internalEngine = gin.Default() -}) -return internalEngine +func init() { +if engine == nil { +engine = gin.Default() +}
How is this different from just writing:
var engine = gin.Default()
? I don't think you can change the value of the engine variable before init is executed, so the if condition will always be true.
In binding/default_validator.go:
> return v.validate } -func (v *defaultValidator) lazyinit() { -v.once.Do(func() { +// lazyInit initialize the validate Settings, no need to use sync.once +func (v *defaultValidator) lazyInit() { +if v.validate == nil {
I'm not sure if this is an improvement. I believe sync.Once was used to avoid race conditions. This version seems kind of safe, too, but it might call validator.New() multiple times unnecessarily. I don't see the point of eliminating sync.Once.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
For the singleton mode implemented by once mechanism, there is no need to use once mechanism here. I think it is more intuitive and clear to judge by nil.
…------------------ Original ------------------
From: daheige ***@***.***>
Date: Mon,Jul 19,2021 7:57 AM
To: reply+ACMGV623UENNAYDFPQQH7KV7AA4DDEVBNHHDQTCOQU ***@***.***>, gin-gonic/gin ***@***.***>
Cc: daheige ***@***.***>, Author ***@***.***>
Subject: Re: [gin-gonic/gin] refactor gin code logic (#2790)
For engine, this is a variable, not the previous function mode. Even if the once mechanism is used, it is recommended to declare it as a private variable mode, which is better and more intuitive.
------------------ Original ------------------
From: daheige ***@***.***>
Date: Mon,Jul 19,2021 7:52 AM
To: reply+ACMGV623UENNAYDFPQQH7KV7AA4DDEVBNHHDQTCOQU ***@***.***>, gin-gonic/gin ***@***.***>
Cc: daheige ***@***.***>, Author ***@***.***>
Subject: Re: [gin-gonic/gin] refactor gin code logic (#2790)
There is no need to use the once mechanism here. You are all using this mechanism indiscriminately.
------------------ Original ------------------
From: kszafran ***@***.***>
Date: Mon,Jul 19,2021 0:30 AM
To: gin-gonic/gin ***@***.***>
Cc: heige ***@***.***>, Author ***@***.***>
Subject: Re: [gin-gonic/gin] refactor gin code logic (#2790)
@kszafran commented on this pull request.
In ginS/gins.go:
> -func engine() *gin.Engine { -once.Do(func() { -internalEngine = gin.Default() -}) -return internalEngine +func init() { +if engine == nil { +engine = gin.Default() +}
How is this different from just writing:
var engine = gin.Default()
? I don't think you can change the value of the engine variable before init is executed, so the if condition will always be true.
In binding/default_validator.go:
> return v.validate } -func (v *defaultValidator) lazyinit() { -v.once.Do(func() { +// lazyInit initialize the validate Settings, no need to use sync.once +func (v *defaultValidator) lazyInit() { +if v.validate == nil {
I'm not sure if this is an improvement. I believe sync.Once was used to avoid race conditions. This version seems kind of safe, too, but it might call validator.New() multiple times unnecessarily. I don't see the point of eliminating sync.Once.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.rename validateHeader to getIPFromHeader
2.fix:shadow: declaration of "err" shadows declaration at line 304
3.lazyInit initialize the validate Settings, no need to use sync.once
4.ginS engine adjust
5.code style adjust