Rust: Compute canonical paths in QL #19134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/canonical-path
branch
5 times, most recently
from
612f797 to
bd478dd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
rust/canonical-path
branch
4 times, most recently
from
774fa8d to
bea7873
Compare
hvitved
force-pushed
the
rust/canonical-path
branch
from
bea7873 to
c17f50a
Compare
| filepath.matches("%/test_logging.rs") and | ||
| startline = 163 | ||
| filepath.matches("%/term.rs") and | ||
| startline = [71] |
Check warning
Code scanning / CodeQL
Singleton set literal Warning
hvitved
force-pushed
the
rust/canonical-path
branch
from
c17f50a to
6c007b5
Compare
hvitved
force-pushed
the
rust/canonical-path
branch
from
6c007b5 to
93c8507
Compare
redsun82
approved these changes
May 21, 2025
There was a problem hiding this comment.
I cannot comment too much on some of the QL involved (like pragmas and language annotations), but on that I will trust you 🙂 feel free to pull someone else in on that if you want another set of 👀
For the rest the general logic behind the code and the test results look good to me.
I think you might be covering more than the test is testing, so maybe consider adding more addressable things in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of canonical path computation in QL. The computed canonical paths are not yet used for anything, but they will eventually be used for mapping Models-as-Data rows to the functions that they model.