C++: Do not use deprecated hasLocationInfo in FlowTestCommon
#19515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Updates test utilities to stop using the deprecated hasLocationInfo directly on dataflow nodes and instead call it on the node’s location.
- Replaces
otherSource.hasLocationInfo(...)withotherSource.getLocation().hasLocationInfo(...) - Applies this change in both the IR and AST flow test modules
| @@ -26,7 +26,7 @@ module IRFlowTest<IRDataFlow::GlobalFlowSig Flow> implements TestSig { | |||
| n = | |||
| strictcount(int line, int column | | |||
| Flow::flow(any(IRDataFlow::Node otherSource | | |||
| otherSource.hasLocationInfo(_, line, column, _, _) | |||
| otherSource.getLocation().hasLocationInfo(_, line, column, _, _) | |||
There was a problem hiding this comment.
[nitpick] Consider extracting the repeated getLocation().hasLocationInfo pattern into a helper predicate or variable to improve readability and reduce duplication across these test modules.
Suggested change
| otherSource.getLocation().hasLocationInfo(_, line, column, _, _) | |
| hasLocationInfo(otherSource, line, column) |
Copilot uses AI. Check for mistakes.
| @@ -55,7 +55,7 @@ module AstFlowTest<AstDataFlow::GlobalFlowSig Flow> implements TestSig { | |||
| n = | |||
| strictcount(int line, int column | | |||
| Flow::flow(any(AstDataFlow::Node otherSource | | |||
| otherSource.hasLocationInfo(_, line, column, _, _) | |||
| otherSource.getLocation().hasLocationInfo(_, line, column, _, _) | |||
There was a problem hiding this comment.
[nitpick] This call is identical to the one above in the IR flow tests; you might centralize it in a shared helper to keep both clauses in sync.
Copilot uses AI. Check for mistakes.
aschackmull
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasLocationInfoon dataflow nodes has been deprecated for over a year.Deprecated in #15853