Go: move to standard windows runner #19525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like `windows-latest-xl` is not available any more. This should unblock CI, but longer term we should consider doing what other languages do (i.e. run tests from the internal repo).
There was a problem hiding this comment.
Pull Request Overview
Updates the Windows CI job to use the supported windows-latest runner and removes the previous repository-owner conditional to unblock builds.
- Switch Windows tests from
windows-latest-xltowindows-latest - Remove
if: github.repository_owner == 'github'guard on the Windows job
Comments suppressed due to low confidence (2)
.github/workflows/go-tests-other-os.yml:28
- Removing the
repository_ownercheck causes this job to run on all forks, which may expose secrets. Consider re-adding a conditional or scoping permissions if this was unintentional.
test-win:
.github/workflows/go-tests-other-os.yml:30
- [nitpick] Switching to
windows-latestrestores runner availability, but verify that it provides equivalent resources and environment for your tests compared towindows-latest-xl.
runs-on: windows-latest
navntoft
approved these changes
May 19, 2025
owen-mc
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like
windows-latest-xlis not available any more, leading to jobs waiting endlessly (see for example https://github.com/github/codeql/actions/runs/15109425790). This should unblock CI, but longer term we should consider doing what other languages do (i.e. run tests from the internal repo).