Quantum: Model missing OpenSSL EVP digest consumers #19545
Merged
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new consumer class for EVP digest algorithm functions (e.g. EVP_get_digestbyname and EVP_MD_fetch).
- Introduce
EVPDigestAlgorithmValueConsumerto capture digest algorithm getters and hook them into the data flow model. - Set up input (
valueArgNode) and result (resultNode) nodes for static analysis.
Comments suppressed due to low confidence (1)
cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmValueConsumers/HashAlgorithmValueConsumer.qll:38
- There are no existing tests for this new consumer; consider adding unit tests to verify detection of EVP_get_digest* and EVP_MD_fetch calls and correct dataflow nodes.
class EVPDigestAlgorithmValueConsumer extends OpenSSLAlgorithmValueConsumer {
cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmValueConsumers/HashAlgorithmValueConsumer.qll
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmValueConsumers/HashAlgorithmValueConsumer.qll
Fixed
Show fixed
Hide fixed
| * EVP digest algorithm getters | ||
| * https://docs.openssl.org/3.0/man3/EVP_DigestInit/#synopsis | ||
| */ | ||
| class EVPDigestAlgorithmValueConsumer extends OpenSSLAlgorithmValueConsumer { |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase. Warning
nicolaswill
changed the title
nicolaswill
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.