Rangeanalysis: Simplify Guards integration. #19571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Range Analysis library uses the second (
_v2
) Java Guards implication logic layer. This implementation detail is leaking all over, so this PR cleans that up by changing the interface to use the controls predicates that are closed under any suitable implication logic, and Java can then simply instantiate it with the proper guards layer without requiring the range analysis to know aboutimplies_v2
.A small semantic effect is that "bound reasons" are now reported as the original comparison rather than the implied guard:
The reason for the bound on
x
atA
is now reported asR1
instead ofR2
. I don't expect this to make much difference in practice.