Rust: Resolve function calls to traits methods #19575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
paldepind
force-pushed
the
rust/function-call-method
branch
from
051938a to
e778cbe
Compare
paldepind
commented
May 26, 2025
| // trait bound on the type parameter. | ||
| result = getTypeParameterMethod(receiver.getTypeAt(TypePath::nil()), receiver.getField()) | ||
| ) | ||
| Function resolveMethodCallTarget(MethodCall mc) { |
There was a problem hiding this comment.
This resolveMethodCallTarget was previously getStaticTarget inside MethodCallExpr. But since we now need for CallExpr as well, I've moved it in here.
paldepind
commented
May 26, 2025
| methodCandidateTrait(rootType, mc.getTrait(), name, arity, impl) | ||
| or | ||
| not exists(mc.getTrait()) and | ||
| methodCandidate(rootType, name, arity, impl) |
There was a problem hiding this comment.
This new disjunct and methodCandidateTrait is the crux of the change.
hvitved
previously approved these changes
May 26, 2025
| */ | ||
| pragma[nomagic] | ||
| private predicate methodCandidateTrait(Type type, Trait trait, string name, int arity, Impl impl) { | ||
| trait = resolvePath(impl.getTrait().(PathTypeRepr).getPath()) and |
There was a problem hiding this comment.
Alternatively, trait = resolvePath(impl.(ImplItemNode).getTraitPath())
hvitved
approved these changes
May 26, 2025
|
DCA seems fine to me. "Missing call targets" went down, but I don't think these trait calls where counted as missing before (because there where resolved to the trait itself), so I think the reduction in missing call targets is a secondary effect since some types are now more accurate, and hence some normal method calls can now be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds resolution for function calls to trait methods
ATrait::some_method(obj, ...).Key changes:
MethodCallabstract class that is extended by the different types of expressions that can lead to method calls. Later this class can also be extended by overloaded operators that perform method calls.methodCandidateTraitpredicate, which is similar to the existingmethodCandidatepredicate but which also takes a trait that the method should come from.potentialInstantiationOfnow accounts both for method calls that target a specific trait.