-
Notifications
You must be signed in to change notification settings - Fork 1.7k
JS: Deprecate type extraction #19640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
asgerf
wants to merge
61
commits into
github:main
Choose a base branch
from
asgerf:js/no-type-extraction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This query depended on the cons-hashing performed by type extraction to determine if two types are the same. This is not trivial to restore, but not important enough to reimplement right now, so for now just simplifying the query's ability to recognise that two types are the same.
This was used in the very old dist-compare tool, but has no use anymore
7ba856a
to
2cd92ef
Compare
Comment on lines
+10
to
+12
/** | ||
* Interface for accessing name-resolution info about type names. | ||
*/ |
Check warning
Code scanning / CodeQL
Class QLDoc style. Warning
The QLDoc for a class should start with 'A', 'An', or 'The'.
Comment on lines
+142
to
+144
/** | ||
* Interface for accessing name-resolution info about expressions. | ||
*/ |
Check warning
Code scanning / CodeQL
Class QLDoc style. Warning
The QLDoc for a class should start with 'A', 'An', or 'The'.
464bb5f
to
973b5ed
Compare
973b5ed
to
d3da502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.