Skip to content

C++: mass enable diff-informed data flow #19663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

C++: mass enable diff-informed data flow #19663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52ce0ef
C++: mass enable diff-informed data flow
d10c Jun 3, 2025
a623657
Add change note
d10c Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/ql/lib/change-notes/2025-06-04-diff-informed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* A number of built-in C++ queries can now run in diff-informed mode.
2 changes: 2 additions & 0 deletions cpp/ql/lib/experimental/semmle/code/cpp/security/PrivateCleartextWrite.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ module PrivateCleartextWrite {
predicate isSink(DataFlow::Node sink) { sink instanceof Sink }

predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer }

predicate observeDiffInformedIncrementalMode() { any() }
}

module WriteFlow = TaintTracking::Global<WriteConfig>;
Expand Down
2 changes: 2 additions & 0 deletions cpp/ql/src/Likely Bugs/Conversion/CastArrayPointerArithmetic.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ module CastToPointerArithFlowConfig implements DataFlow::StateConfigSig {
predicate isBarrierIn(DataFlow::Node node) { isSource(node, _) }

predicate isBarrierOut(DataFlow::Node node) { isSink(node, _) }

predicate observeDiffInformedIncrementalMode() { any() }
}

/**
Expand Down
2 changes: 2 additions & 0 deletions cpp/ql/src/Likely Bugs/Memory Management/NtohlArrayNoBound.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ private module NetworkToBufferSizeConfig implements DataFlow::ConfigSig {
gc.controls(node.asExpr().getBasicBlock(), _)
)
}

predicate observeDiffInformedIncrementalMode() { any() }
}

module NetworkToBufferSizeFlow = DataFlow::Global<NetworkToBufferSizeConfig>;
2 changes: 2 additions & 0 deletions cpp/ql/src/Security/CWE/CWE-114/UncontrolledProcessOperation.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ module Config implements DataFlow::ConfigSig {
or
node.asCertainDefinition().getUnspecifiedType() instanceof ArithmeticType
}

predicate observeDiffInformedIncrementalMode() { any() }
}

module Flow = TaintTracking::Global<Config>;
Expand Down
2 changes: 2 additions & 0 deletions cpp/ql/src/Security/CWE/CWE-129/ImproperArrayIndexValidation.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ module ImproperArrayIndexValidationConfig implements DataFlow::ConfigSig {
not offsetIsAlwaysInBounds(arrayExpr, offsetExpr)
)
}

predicate observeDiffInformedIncrementalMode() { any() }
}

module ImproperArrayIndexValidation = TaintTracking::Global<ImproperArrayIndexValidationConfig>;
Expand Down
2 changes: 2 additions & 0 deletions cpp/ql/src/Security/CWE/CWE-134/UncontrolledFormatString.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ module Config implements DataFlow::ConfigSig {
or
isArithmeticNonCharType(node.asCertainDefinition().getUnspecifiedType())
}

predicate observeDiffInformedIncrementalMode() { any() }
}

module Flow = TaintTracking::Global<Config>;
Expand Down
2 changes: 2 additions & 0 deletions cpp/ql/src/Security/CWE/CWE-190/IntegerOverflowTainted.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ module Config implements DataFlow::ConfigSig {
not iTo instanceof PointerArithmeticInstruction
)
}

predicate observeDiffInformedIncrementalMode() { any() }
}

module Flow = TaintTracking::Global<Config>;
Expand Down
2 changes: 2 additions & 0 deletions cpp/ql/src/Security/CWE/CWE-497/ExposedSystemData.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ module ExposedSystemDataConfig implements DataFlow::ConfigSig {
predicate isBarrier(DataFlow::Node node) {
node.asIndirectArgument() = any(MemsetFunction func).getACallToThisFunction().getAnArgument()
}

predicate observeDiffInformedIncrementalMode() { any() }
}

module ExposedSystemData = TaintTracking::Global<ExposedSystemDataConfig>;
Expand Down
2 changes: 2 additions & 0 deletions cpp/ql/src/Security/CWE/CWE-497/PotentiallyExposedSystemData.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ module PotentiallyExposedSystemDataConfig implements DataFlow::ConfigSig {
predicate isBarrier(DataFlow::Node node) {
node.asIndirectArgument() = any(MemsetFunction func).getACallToThisFunction().getAnArgument()
}

predicate observeDiffInformedIncrementalMode() { any() }
}

module PotentiallyExposedSystemData = TaintTracking::Global<PotentiallyExposedSystemDataConfig>;
Expand Down
2 changes: 2 additions & 0 deletions cpp/ql/src/Security/CWE/CWE-611/XXE.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ module XxeConfig implements DataFlow::StateConfigSig {
}

predicate neverSkip(DataFlow::Node node) { none() }

predicate observeDiffInformedIncrementalMode() { any() }
}

module XxeFlow = DataFlow::GlobalWithState<XxeConfig>;
Expand Down
2 changes: 2 additions & 0 deletions cpp/ql/src/experimental/Security/CWE/CWE-078/WordexpTainted.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ module WordexpTaintConfig implements DataFlow::ConfigSig {
predicate isBarrier(DataFlow::Node node) {
node.asExpr().getUnspecifiedType() instanceof IntegralType
}

predicate observeDiffInformedIncrementalMode() { any() }
}

module WordexpTaint = TaintTracking::Global<WordexpTaintConfig>;
Expand Down
2 changes: 2 additions & 0 deletions cpp/ql/src/experimental/Security/CWE/CWE-190/AllocMultiplicationOverflow.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ module MultToAllocConfig implements DataFlow::ConfigSig {
// something that affects an allocation size
node.asExpr() = any(HeuristicAllocationExpr ae).getSizeExpr().getAChild*()
}

predicate observeDiffInformedIncrementalMode() { any() }
}

module MultToAlloc = DataFlow::Global<MultToAllocConfig>;
Expand Down