Skip to content

Config Updates #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2025
Merged

Config Updates #63

merged 5 commits into from
Jun 18, 2025

Conversation

GrantBirki
Copy link
Member

No description provided.

…related tests. All refs to the handler dir must be made through `handler_plugin_dir` going forward to be consistent
@Copilot Copilot AI review requested due to automatic review settings June 18, 2025 19:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the legacy handler_dir configuration to handler_plugin_dir across tests, schema, loader, and documentation.

  • Updated specs to use handler_plugin_dir
  • Removed handler_dir from the Dry schema and environment mappings
  • Revised docs to reflect handler_plugin_dir

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
spec/unit/lib/hooks/core/config_validator_spec.rb Updated tests to replace handler_dir with handler_plugin_dir
lib/hooks/core/config_validator.rb Removed handler_dir from the global config schema
lib/hooks/core/config_loader.rb Dropped legacy HOOKS_HANDLER_DIR environment mapping
docs/design.md Updated configuration references to handler_plugin_dir
Comments suppressed due to low confidence (3)

lib/hooks/core/config_loader.rb:129

  • Removing the legacy HOOKS_HANDLER_DIR mapping breaks backward compatibility; consider mapping it to handler_plugin_dir with a deprecation warning.
        env_mappings = {

docs/design.md:350

  • [nitpick] The term plugin_dir is not defined in the schema—clarify whether this refers to auth_plugin_dir, lifecycle_plugin_dir, or both.
* Plugin classes are loaded from `plugin_dir` and registered based on class inheritance

lib/hooks/core/config_loader.rb:130

  • Add a unit test to verify that HOOKS_HANDLER_PLUGIN_DIR is correctly loaded into handler_plugin_dir in the environment config loader.
          "HOOKS_HANDLER_PLUGIN_DIR" => :handler_plugin_dir,

@GrantBirki GrantBirki merged commit 29df8ab into main Jun 18, 2025
22 checks passed
@GrantBirki GrantBirki deleted the config-updates branch June 18, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant