feat(monitor): add basic-auth feature for protected sites #367
+19
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes issue #316
This feature properly resolves sites that require basic auth credentials, so that it properly returns status
OK
instead ofUnauthorized
.At the very least, this can replace using
alt-status-codes
and adding401
to it, which is like a "bogus" statusOK
(although if the intent is to just ping the site if its alive, then its good enough of a solution).Furthermore, this could be expanded to also pass the configured basic auth credentials to the request when the user clicks on the specific monitor widget.