Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monitor): add basic-auth feature for protected sites #367

Merged
merged 3 commits into from
Feb 22, 2025

Conversation

ejsadiarin
Copy link

@ejsadiarin ejsadiarin commented Feb 19, 2025

this closes issue #316

This feature properly resolves sites that require basic auth credentials, so that it properly returns status OK instead of Unauthorized.

At the very least, this can replace using alt-status-codes and adding 401 to it, which is like a "bogus" status OK (although if the intent is to just ping the site if its alive, then its good enough of a solution).

- type: monitor
  cache: 1m
  title: Services
  sites:
    - title: Traefik
      url: https://traefik.example.com
      icon: di:traefik
      basic-auth:
        username: your-username
        password: your-password

Furthermore, this could be expanded to also pass the configured basic auth credentials to the request when the user clicks on the specific monitor widget.

this closes [issue glanceapp#316](glanceapp#316)

Furthermore, this could be expanded to also pass the configured basic
auth credentials to the request when the user clicks on the specific
monitor widget
@ejsadiarin ejsadiarin changed the title feat(monitor): add basic-auth feature for protected sites that require basic auth credentials (with documentation) feat(monitor): add basic-auth feature for protected sites Feb 19, 2025
Copy link
Member

@svilenmarkov svilenmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@svilenmarkov svilenmarkov merged commit 4d6600b into glanceapp:dev Feb 22, 2025
@svilenmarkov svilenmarkov added this to the v0.8.0 milestone Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants