Update proptypes for contentId and triggerElementProps #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I resolved the failing tests in my local project by |
Use constant for Date.now()
|
Ok cool I'll close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry the pull request isn't completely proper, I just had to test a few things for my own sake. You could take over this PR and do as you wish, merge it or decline it, up to you.
I had updated the dependency for react-collapsible in my local project and my snapshot tests were failing because of the
date()function. I also thought I could specify the props a bit better rather than just "object". Although I'm sure some props are missing, feel free to add in.