Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed behaviour of hsm buttons. #3176

Merged
merged 10 commits into from
Jan 11, 2025
Merged

Fixed behaviour of hsm buttons. #3176

merged 10 commits into from
Jan 11, 2025

Conversation

akanshaaa19
Copy link
Member

@akanshaaa19 akanshaaa19 commented Jan 6, 2025

target issue is #3175

@akanshaaa19 akanshaaa19 linked an issue Jan 6, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jan 6, 2025

@github-actions github-actions bot temporarily deployed to pull request January 6, 2025 03:49 Inactive
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.88%. Comparing base (6a4524d) to head (7edec63).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/containers/HSM/HSM.tsx 79.16% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3176      +/-   ##
==========================================
- Coverage   81.89%   81.88%   -0.02%     
==========================================
  Files         327      327              
  Lines       10516    10526      +10     
  Branches     2170     2174       +4     
==========================================
+ Hits         8612     8619       +7     
- Misses       1295     1298       +3     
  Partials      609      609              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jan 6, 2025

Glific    Run #5496

Run Properties:  status check passed Passed #5496  •  git commit 55ebc191c6 ℹ️: Merge 7edec639305fc2289c31658f43d965cd0374b13d into 6a4524dd3eb37eba87047f2f59f1...
Project Glific
Branch Review enhancements/hsm-buttons
Run status status check passed Passed #5496
Run duration 26m 22s
Commit git commit 55ebc191c6 ℹ️: Merge 7edec639305fc2289c31658f43d965cd0374b13d into 6a4524dd3eb37eba87047f2f59f1...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 172
View all changes introduced in this branch ↗︎

@akanshaaa19 akanshaaa19 linked an issue Jan 6, 2025 that may be closed by this pull request
@github-actions github-actions bot temporarily deployed to pull request January 6, 2025 10:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 8, 2025 05:17 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund January 8, 2025 05:20
@github-actions github-actions bot temporarily deployed to pull request January 8, 2025 05:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 8, 2025 06:04 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me and fixes the reported issue.

@kurund kurund merged commit 3e82e09 into master Jan 11, 2025
12 of 13 checks passed
@kurund kurund deleted the enhancements/hsm-buttons branch January 11, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HSM: Template buttons not working smoothly
2 participants