Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dynamic links to buttons #3180

Merged
merged 5 commits into from
Jan 13, 2025
Merged

added dynamic links to buttons #3180

merged 5 commits into from
Jan 13, 2025

Conversation

akanshaaa19
Copy link
Member

@akanshaaa19 akanshaaa19 commented Jan 8, 2025

target issue is #3157

@akanshaaa19 akanshaaa19 requested a review from kurund January 8, 2025 06:18
@akanshaaa19 akanshaaa19 linked an issue Jan 8, 2025 that may be closed by this pull request
Base automatically changed from enhancements/hsm-buttons to master January 11, 2025 15:21
Copy link

github-actions bot commented Jan 11, 2025

@github-actions github-actions bot temporarily deployed to pull request January 11, 2025 15:23 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check on test failures.

@kurund
Copy link
Contributor

kurund commented Jan 11, 2025

@akanshaaa19

Looks like now the tests are failing as other PR is merged. Can you please check.

Copy link

cypress bot commented Jan 11, 2025

Glific    Run #5501

Run Properties:  status check passed Passed #5501  •  git commit a82dc582b2 ℹ️: Merge 8a3547b1fe994bf21166c1bc6befbfb2103291e1 into 3e82e09a95b20041c02baf091f1f...
Project Glific
Branch Review template/dynamic-url
Run status status check passed Passed #5501
Run duration 25m 36s
Commit git commit a82dc582b2 ℹ️: Merge 8a3547b1fe994bf21166c1bc6befbfb2103291e1 into 3e82e09a95b20041c02baf091f1f...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 172
View all changes introduced in this branch ↗︎

@github-actions github-actions bot temporarily deployed to pull request January 12, 2025 05:38 Inactive
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.82%. Comparing base (3e82e09) to head (8a3547b).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/containers/TemplateOptions/TemplateOptions.tsx 28.57% 3 Missing and 2 partials ⚠️
src/containers/HSM/HSM.tsx 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3180      +/-   ##
==========================================
- Coverage   81.85%   81.82%   -0.03%     
==========================================
  Files         327      327              
  Lines       10526    10539      +13     
  Branches     2174     2177       +3     
==========================================
+ Hits         8616     8624       +8     
- Misses       1300     1303       +3     
- Partials      610      612       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kurund kurund merged commit 4976ab5 into master Jan 13, 2025
10 of 13 checks passed
@kurund kurund deleted the template/dynamic-url branch January 13, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HSM Template: Not being able to apply links with variables
2 participants