Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issue #120 by allowing job methods to be chained. #125

Merged
merged 6 commits into from
Feb 16, 2019
Merged

Resolve issue #120 by allowing job methods to be chained. #125

merged 6 commits into from
Feb 16, 2019

Conversation

bdice
Copy link
Member

@bdice bdice commented Feb 16, 2019

See issue #120 for description.

I also looked at the possibility of chaining calls to Project, but there were no candidate methods that I thought would be good to chain.

@bdice bdice added enhancement New feature or request Job labels Feb 16, 2019
@bdice bdice self-assigned this Feb 16, 2019
@bdice bdice requested a review from a team February 16, 2019 01:25
@bdice bdice requested a review from csadorf as a code owner February 16, 2019 01:25
@bdice
Copy link
Member Author

bdice commented Feb 16, 2019

@csadorf This should be ready for review.

csadorf
csadorf approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor request, otherwise perfect! Thank you very much.

signac/contrib/job.py Outdated Show resolved Hide resolved
csadorf
csadorf approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@csadorf csadorf merged commit 98a87e6 into develop Feb 16, 2019
@csadorf csadorf deleted the feature/job-chaining branch February 16, 2019 15:35
@csadorf csadorf mentioned this pull request Feb 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csadorf csadorf csadorf approved these changes

Assignees

@bdice bdice

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @csadorf