Mail authentication can be set as default (works together with LDAP auth)

[SebSept]

Checklist before requesting a review

Please delete options that are not relevant.

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

• It continues Add make default option for authmails #16221

Review

It's current a WIP PR.
It does the job but some things may require changes or at least some feedback, for me as glpi new contributor. These are marked with @todo annotations in the code.

By the way I used another way to write test :

• I did'nt use phpunit assertions to check to tests preparation, I use php native assert() which also trigger failure if needed but do not count as test. I also help to distinguish between real test assertion failures and test preparation failures. I think this is the way we are supposed to write assertion.
• because these tests are functionnal and not unit test, I used a more appropriate naming which describe the behaviour without naming functions (that good for unit test only).

[cedric-anne]

This method should probably be moved in the Auth class itself.

[cedric-anne]

Here is how to trigger a deprecation message in GLPI.

Suggested change

	// @todo trigger deprecation ?
	Toolbox::deprecated('The `AuthLDAP::getDefault()` method is deprecated, use `class::method()` instead.');

[cedric-anne]

I know you copied the existing code, but we should avoid using low level methods directly to update an item, as they prevent plugins hooks to be able to handle the corresponding operations. You should replace DBmysql::update() by CommonDBTM::update() here. It requires some refactoring, as you will have first to fetch the existing default server, if any, and the update it.

Same remark for the AuthMail update.

[SebSept]

:/ It doesn't look like CommonDBTM::update() give the ability to update multiple items with a where criteria.