Skip to content

Commit

Permalink
Remove -q/--quiet from pip invocations. (certbot#6568)
Browse files Browse the repository at this point in the history
While reducing noise in test output is valuable, this flag has made a couple aspects of Certbot's development difficult:

1. We test with different sets of dependencies and running pip in quiet mode removes all output about the packages being installed which has made reviewing changes to these tests more difficult.
2. When pip fails, it provides significantly less output about the failure in quiet mode than it does normally. The output is reduced so much that in the two times I've hit this issue in the last month, I was only able to see that installing package X failed rather than what the cause of that failure was which could be seen with `--quiet` removed.

Also, since running pip without `--quiet` is the tox default, I expect Python developers to be familiar with what they see here.
  • Loading branch information
bmw authored Dec 7, 2018
1 parent adedcc6 commit 353d092
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions tools/install_and_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def call_with_print(command, cwd=None):

def main(args):
if os.environ.get('CERTBOT_NO_PIN') == '1':
command = [sys.executable, '-m', 'pip', '-q', '-e']
command = [sys.executable, '-m', 'pip', '-e']
else:
script_dir = os.path.dirname(os.path.abspath(__file__))
command = [sys.executable, os.path.join(script_dir, 'pip_install_editable.py')]
Expand All @@ -50,7 +50,7 @@ def main(args):
shutil.copy2("pytest.ini", temp_cwd)
try:
call_with_print(' '.join([
sys.executable, '-m', 'pytest', '--quiet', pkg.replace('-', '_')]), cwd=temp_cwd)
sys.executable, '-m', 'pytest', pkg.replace('-', '_')]), cwd=temp_cwd)
finally:
shutil.rmtree(temp_cwd)

Expand Down
4 changes: 2 additions & 2 deletions tools/pip_install.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ def main(args):

merge_requirements(tools_path, test_constraints, all_constraints)
if requirements:
call_with_print('"{0}" -m pip install -q --constraint "{1}" --requirement "{2}"'
call_with_print('"{0}" -m pip install --constraint "{1}" --requirement "{2}"'
.format(sys.executable, all_constraints, requirements))

call_with_print('"{0}" -m pip install -q --constraint "{1}" {2}'
call_with_print('"{0}" -m pip install --constraint "{1}" {2}'
.format(sys.executable, all_constraints, ' '.join(args)))
finally:
shutil.rmtree(working_dir)
Expand Down

0 comments on commit 353d092

Please sign in to comment.