Fix mmdebstrap action #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nbuchwitz Could you check this PR? |
|
Hm looks like something is double-escaping the string. I've tested your patches and can confirm that this fixes the issue. Thanks for also adding tests for this! -> LGTM |
nbuchwitz
approved these changes
Mar 3, 2025
|
@sjoerdsimons unfortunately this slipped trough in my initial MR. This should go into the release too |
|
@sjoerdsimons looks good to me. I will let you review too |
sjoerdsimons
reviewed
Mar 3, 2025
thanks looks like we'll need to fix the arch build to get the pipeline green against first |
…pkgopt and aptopt
Remove single quotation (') from the append strings of dpkgopt and aptopt.
The mmdebstrap process fails because the format contains single quotation.
Debos yaml file:
```
architecture: amd64
actions:
- action: mmdebstrap
suite: sid
variant: minbase
merged-usr: true
dpkg-opts:
- path-exclude=/usr/share/man/*
```
Error message:
```
[...]
2025/03/03 06:59:12 Mmdebstrap | dpkg: error: configuration error: /etc/dpkg/dpkg.cfg.d/99mmdebstrap:1: unknown option ''
[...]
```
From debug message of mmdebstrap:
```
[...]
D: 1 3180 content of /etc/dpkg/dpkg.cfg.d/99mmdebstrap:
'path-exclude=/usr/share/man/*' <--here
apt 2.9.30 (amd64)
Supported modules:
*Ver: Standard .deb
[...]
```
Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
sjoerdsimons
force-pushed
the
fix-mmdebstrap
branch
from
8bb8444 to
ddd1c63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mmdebstrap process fails because the format contains single quotation.
To fix this, remove single quotation (') from the append strings of dpkgopt and aptopt.
Debos yaml file:
Error message:
From debug message of mmdebstrap: