Squash merge messages contain information about all commits by default. #35247
Conversation
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/go
hiifong
force-pushed
the
squash-merge-msg
branch
from
fca67b7 to
d328e00
Compare
github-actions
bot
removed
modifies/translation
modifies/templates
|
Please split And it needs tests to cover the changed logic (although old code doesn't have enough tests, new code should have when the logic is complex) |
|
This part seems not right, 
|
Done. 
|
|
Let me spend some time researching how to add tests. |
|
Style nit: there should be no empty line between such metadata lines. |
* main: [skip ci] Updated translations via Crowdin Fix LFS range size header response (go-gitea#35277) Skip "parentsigned" check when the repo is empty (go-gitea#35292) [skip ci] Updated translations via Crowdin Fix GitHub release assets URL validation (go-gitea#35287) nix flake use go1.25 (go-gitea#35288) go1.25.0 (go-gitea#35262)
| commitsBuilder := strings.Builder{} | ||
| for _, c := range compareInfo.Commits { | ||
| commitsBuilder.WriteString("* ") | ||
| commitsBuilder.WriteString(c.CommitMessage) |
There was a problem hiding this comment.
In this case, I would consider it an abuse of commit messages. I believe that squash merge should be an independent feature branch, and I find it hard to believe that every commit message contains so much information. Therefore, I consider this to be an extreme scenario.
There was a problem hiding this comment.
I’ve submitted f37de47 to address the issue. This isn’t an uncommon case—many commits include multi-line messages. Do you know how GitHub handles this?
There was a problem hiding this comment.
ref: hiifong/squash-test@beaa913
GitHub's squash merge does not include the PR description, and there seems to be no limit on the length of the commit message.
This behavior is basically the same as GitHub, except for the dividing line I added.
screenshot: