Skip to content

Commit

Permalink
cmake: remove unnecessary target_include_directories() for spawn
Browse files Browse the repository at this point in the history
targets that depend on spawn via target_link_libraries() automatically
pull in their compile options and include directories

Signed-off-by: Casey Bodley <[email protected]>
  • Loading branch information
cbodley committed Feb 3, 2021
1 parent 603c88e commit 94b4949
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
4 changes: 0 additions & 4 deletions src/test/cls_fifo/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
add_executable(ceph_test_cls_fifo
test_cls_fifo.cc
)
target_include_directories(ceph_test_cls_fifo PRIVATE
$<TARGET_PROPERTY:spawn,INTERFACE_INCLUDE_DIRECTORIES>)
target_link_libraries(ceph_test_cls_fifo
neorados_cls_fifo
libneorados
Expand All @@ -21,8 +19,6 @@ install(TARGETS
add_executable(ceph_bench_cls_fifo
bench_cls_fifo.cc
)
target_include_directories(ceph_bench_cls_fifo PRIVATE
$<TARGET_PROPERTY:spawn,INTERFACE_INCLUDE_DIRECTORIES>)
target_link_libraries(ceph_bench_cls_fifo
neorados_cls_fifo
libneorados
Expand Down
2 changes: 0 additions & 2 deletions src/tools/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ if(NOT WIN32)
set(neorados_srcs
neorados.cc)
add_executable(neorados ${neorados_srcs})
target_include_directories(neorados PRIVATE
$<TARGET_PROPERTY:spawn,INTERFACE_INCLUDE_DIRECTORIES>)
target_link_libraries(neorados libneorados spawn ${CMAKE_DL_LIBS})
#install(TARGETS neorados DESTINATION bin)
endif()
Expand Down

0 comments on commit 94b4949

Please sign in to comment.