[mbedTLS] Integrate TLS handshake defragmentation PR #102770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
force-pushed
the
mbedtls/backport_9949_defragment_tls_handshake
branch
from
b29b2ee to
d6cdc5b
Compare
This was referenced Feb 12, 2025
Calinou
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Tested locally on Linux, it works as expected.
I prefer this to #102774 personally, but note that this means builds with builtin_mbedtls=no won't be able to contact TLS 1.3 services, while builds using built-in mbedTLS will. This should be noted in the class reference for HTTPClient and HTTPRequest, as Linux distribution builds of Godot will be impacted by this.
The Godot Flatpak already uses built-in mbedTLS, so it should be fine.
|
New upstream backport PR: Mbed-TLS/mbedtls#9981 We're on cutting edge material 😅 I think this, and the point Calinou made about distro packages, calls for going with #102774 for Godot 4.4. |
|
Re-opened as #103247 (hopefully for the last time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate upstream PR Mbed-TLS/mbedtls#9949
Opening as draft for now since I don't really like the idea of integrating an unmerged upstream PR in such a critical component.
Fixes #101910 .