Update dependency typescript to ^3.6.3 (sourcegraph#5390)

* Update dependency typescript to ^3.6.3 * Fix Notification story
golang-info · Sep 10, 2019 · bee5c81 · bee5c81
1 parent c2ef6d2
commit bee5c81
Show file tree

Hide file tree

Showing 9 changed files with 29 additions and 26 deletions.
diff --git a/cmd/management-console/web/package.json b/cmd/management-console/web/package.json
@@ -13,6 +13,6 @@
     "monaco-editor": "^0.17.1",
     "node-sass": "^4.12.0",
     "parcel-bundler": "^1.12.3",
-    "typescript": "^3.5.3"
+    "typescript": "^3.6.3"
   }
 }
diff --git a/cmd/management-console/web/yarn.lock b/cmd/management-console/web/yarn.lock
@@ -5345,10 +5345,10 @@ typedarray@^0.0.6:
   resolved "https://registry.npmjs.org/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
-typescript@^3.5.3:
-  version "3.5.3"
-  resolved "https://registry.npmjs.org/typescript/-/typescript-3.5.3.tgz#c830f657f93f1ea846819e929092f5fe5983e977"
-  integrity sha512-ACzBtm/PhXBDId6a6sDJfroT2pOWt/oOnk4/dElG5G33ZL776N3Y6/6bKZJBFpd+b05F3Ct9qDjMeJmRWtE2/g==
+typescript@^3.6.3:
+  version "3.6.3"
+  resolved "https://registry.npmjs.org/typescript/-/typescript-3.6.3.tgz#fea942fabb20f7e1ca7164ff626f1a9f3f70b4da"
+  integrity sha512-N7bceJL1CtRQ2RiG0AQME13ksR7DiuQh/QehubYcghzv20tnh+MQnQIuJddTmsbqYj+dztchykemz0zFzlvdQw==
 
 uncss@^0.16.2:
   version "0.16.2"

diff --git a/lsif/extension/package.json b/lsif/extension/package.json
@@ -46,7 +46,7 @@
     "parcel-bundler": "^1.12.3",
     "sourcegraph": "^23.0.1",
     "tslint": "^5.19.0",
-    "typescript": "^3.5.3"
+    "typescript": "^3.6.3"
   },
   "dependencies": {
     "@sourcegraph/lsp-client": "^2.0.0-beta.2",

diff --git a/lsif/extension/yarn.lock b/lsif/extension/yarn.lock
@@ -5375,10 +5375,10 @@ typedarray@^0.0.6:
   resolved "https://registry.npmjs.org/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
-typescript@^3.5.3:
-  version "3.5.3"
-  resolved "https://registry.npmjs.org/typescript/-/typescript-3.5.3.tgz#c830f657f93f1ea846819e929092f5fe5983e977"
-  integrity sha512-ACzBtm/PhXBDId6a6sDJfroT2pOWt/oOnk4/dElG5G33ZL776N3Y6/6bKZJBFpd+b05F3Ct9qDjMeJmRWtE2/g==
+typescript@^3.6.3:
+  version "3.6.3"
+  resolved "https://registry.npmjs.org/typescript/-/typescript-3.6.3.tgz#fea942fabb20f7e1ca7164ff626f1a9f3f70b4da"
+  integrity sha512-N7bceJL1CtRQ2RiG0AQME13ksR7DiuQh/QehubYcghzv20tnh+MQnQIuJddTmsbqYj+dztchykemz0zFzlvdQw==
 
 uncss@^0.16.2:
   version "0.16.2"

diff --git a/lsif/server/package.json b/lsif/server/package.json
@@ -31,7 +31,7 @@
     "parcel-bundler": "^1.12.3",
     "tsc-watch": "^2.2.1",
     "tslint": "^5.19.0",
-    "typescript": "^3.5.3"
+    "typescript": "^3.6.3"
   },
   "scripts": {
     "typecheck": "tsc -p .",

diff --git a/lsif/server/yarn.lock b/lsif/server/yarn.lock
@@ -5413,10 +5413,10 @@ typedarray@^0.0.6:
   resolved "https://registry.npmjs.org/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
-typescript@^3.5.3:
-  version "3.5.3"
-  resolved "https://registry.npmjs.org/typescript/-/typescript-3.5.3.tgz#c830f657f93f1ea846819e929092f5fe5983e977"
-  integrity sha512-ACzBtm/PhXBDId6a6sDJfroT2pOWt/oOnk4/dElG5G33ZL776N3Y6/6bKZJBFpd+b05F3Ct9qDjMeJmRWtE2/g==
+typescript@^3.6.3:
+  version "3.6.3"
+  resolved "https://registry.npmjs.org/typescript/-/typescript-3.6.3.tgz#fea942fabb20f7e1ca7164ff626f1a9f3f70b4da"
+  integrity sha512-N7bceJL1CtRQ2RiG0AQME13ksR7DiuQh/QehubYcghzv20tnh+MQnQIuJddTmsbqYj+dztchykemz0zFzlvdQw==
 
 uncss@^0.17.0:
   version "0.17.0"

diff --git a/package.json b/package.json
@@ -188,7 +188,7 @@
     "terser-webpack-plugin": "^1.4.1",
     "ts-node": "^8.3.0",
     "tslint": "^5.19.0",
-    "typescript": "^3.5.3",
+    "typescript": "^3.6.3",
     "utc-version": "^2.0.1",
     "web-ext": "npm:@sourcegraph/web-ext@^3.0.0-fork.1",
     "webpack": "^4.39.3",

diff --git a/shared/src/notifications/NotificationItem.story.tsx b/shared/src/notifications/NotificationItem.story.tsx
@@ -18,11 +18,16 @@ const { add } = storiesOf('NotificationItem', module).addDecorator(story => (
 ))
 
 for (const [name, type] of Object.entries(NotificationType)) {
+    // TS enums are reverse-indexed, so filter the number keys out
+    if (!isNaN(parseInt(name, 10))) {
+        continue
+    }
+
     add(name, () => (
         <NotificationItem
             notification={{
                 message: 'Formatted *message*',
-                type,
+                type: type as NotificationTypeType,
             }}
             onDismiss={onDismiss}
         />
@@ -31,7 +36,7 @@ for (const [name, type] of Object.entries(NotificationType)) {
     add(`${name} - Progress`, () => (
         <NotificationItem
             notification={{
-                type,
+                type: type as NotificationTypeType,
                 progress: interval(100).pipe(
                     startWith(0),
                     map(i => ({

diff --git a/yarn.lock b/yarn.lock
@@ -1619,8 +1619,7 @@
   integrity sha512-Te7F1RQJLBH4C8wQ2xz0nPC2vpe13F80V+Yv+c3GySOoh4DcLNN4P5u51Kh4aZPqeS5DJ7CKvHyX2SM/1EBXNg==
 
 "@sourcegraph/extension-api-types@link:packages/@sourcegraph/extension-api-types":
-  version "0.0.0"
-  uid ""
+  version "2.0.0"
 
 "@sourcegraph/prettierrc@^3.0.1":
   version "3.0.1"
@@ -15868,8 +15867,7 @@ source-map@^0.7.2, source-map@^0.7.3:
   integrity sha512-CkCj6giN3S+n9qrYiBTX5gystlENnRW5jZeNLHpe6aue+SrHcG5VYwujhW9s4dY31mEGsxBDrHR6oI69fTXsaQ==
 
 "sourcegraph@link:packages/sourcegraph-extension-api":
-  version "0.0.0"
-  uid ""
+  version "23.0.1"
 
 space-separated-tokens@^1.0.0:
   version "1.1.2"
@@ -17066,10 +17064,10 @@ typedarray@^0.0.6:
   resolved "https://registry.npmjs.org/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
-typescript@^3.5.3:
-  version "3.5.3"
-  resolved "https://registry.npmjs.org/typescript/-/typescript-3.5.3.tgz#c830f657f93f1ea846819e929092f5fe5983e977"
-  integrity sha512-ACzBtm/PhXBDId6a6sDJfroT2pOWt/oOnk4/dElG5G33ZL776N3Y6/6bKZJBFpd+b05F3Ct9qDjMeJmRWtE2/g==
+typescript@^3.6.3:
+  version "3.6.3"
+  resolved "https://registry.npmjs.org/typescript/-/typescript-3.6.3.tgz#fea942fabb20f7e1ca7164ff626f1a9f3f70b4da"
+  integrity sha512-N7bceJL1CtRQ2RiG0AQME13ksR7DiuQh/QehubYcghzv20tnh+MQnQIuJddTmsbqYj+dztchykemz0zFzlvdQw==
 
 ua-parser-js@^0.7.18:
   version "0.7.19"